New parameters API from ProtoData#180
Merged
alexander-yevsyukov merged 3 commits intomasterfrom Jan 4, 2025
Merged
Conversation
armiol
approved these changes
Jan 4, 2025
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates to latest version of ProtoData, adopting API changes in production code and tests. Sections below describe the changes in details.
ProtoDataConfigPluginnow usesWorkingDirectoryconventionsPreviously, the path to the settings directory was obtained from the
CreateSettingsDirectorytask added by ProtoData Gradle plugin. The new version no longer adds the task, andProtoDataConfigPluginnow uses the conventional settings directory returned by theWorkingDirectoryclass.Consolidated test directories
Tests now use only one
projectDir. Previously,ouputDirandsettingsDirwere also used. Now these directories are created under theprojectDir. This simplifies the analysis of the parameters, settings, and the generated code during debugging.